Add MARC21/XML support #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ST_GeomFromMARC21: extracts geometries from MARC21 documents - ST_AsMARC21: generates MARC21 documents from geometries
strk
pushed a commit
that referenced
this pull request
Feb 8, 2022
pramsey
reviewed
Feb 8, 2022
|
@pramsey @jimjonesbr Are we ready to push this thru now? |
@robe2 I've already addressed the points made by @pramsey and @strk, except the suggestion of @pramsey to use regex in a specific function. Nevertheless, I refactored it to make things more readable and avoid memcpy calls (I hope it is more palatable now: #11bedb6). I was waiting for the other reviewers to make any further change to the code. |
pramsey
reviewed
Feb 15, 2022
pramsey
reviewed
Feb 15, 2022
pramsey
reviewed
Feb 15, 2022
pramsey
reviewed
Feb 15, 2022
pramsey
reviewed
Feb 15, 2022
pramsey
reviewed
Feb 15, 2022
- adds null check in the literal input in 'is_literal_valid - removes unnecessary lwgeom_free(geom) in 'ST_GeomFromMARC21' - changes '$libdir/postgis-3' to 'MODULE_PATH' in PLpg/SQL function - changes 'PG_GETARG_GSERIALIZED_P_COPY' to 'PG_GETARG_GSERIALIZED_P' in 'ST_AsMARC21' - changes sprintf calls to snprintf in 'corner_to_subfield_sb'
pramsey
approved these changes
Feb 15, 2022
|
Anyone else have anything to say before I commit this. I'm going to ignore the cloud drone failure since the PG 11 run passed and looked like the rest was just halted for some reason. |
|
This has been squashed into master now. |
|
Tests are failing on 32bit architecture (rounding?): https://gitlab.com/postgis/postgis/-/pipelines/473567768 |
@strk Yes, it's a rounding problem. It seems I accidentally skipped the roundoff ST_AsTest(geom, 5) in a few test cases |
|
@jimjonesbr Still getting slight rounding issue on windows - https://trac.osgeo.org/postgis/ticket/5104 E129.258333333333325754210818558931350708007812 vs. E129.258333333333325754210818558931350708007813 |
Hi @robe2. These tests were originally designed to make sure one can create coordinates in marc with as much decimal places as wanted... but now I see it creates too much trouble across architectures and platforms. I will send a PR with an alternative test. |
|
Hi @robe2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions ST_AsMARC21 and ST_GeomFromMARC21 with their XML documentation files and regression tests.